Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"allowEmpty" property for UCI options. Disallow empty values for net file. #3668

Closed

Conversation

Sopel97
Copy link
Member

@Sopel97 Sopel97 commented Aug 20, 2021

This seems to break the case when EvalFile is set to blank:

setoption name EvalFile value
go infinite
info string ERROR: If the UCI option "Use NNUE" is set to true, network evaluation parameters compatible with the engine must be available.
info string ERROR: The option is set to true, but the network file  was not loaded successfully.
...

It's useful to set this to blank in a GUI (e.g. cutechess GUI) so that when you download new dev versions with new nets, you don't have to manually change the EvalFile parameter each time. I thought this was supported functionality (but I could be wrong)

This PR brings back the previous behaviour for this particular uci option, as setting empty strings as paths to the networks doesn't make much sense we should revert to the previous.

…e possible. Disallow empty values for net file.
@vondele
Copy link
Member

vondele commented Aug 27, 2021

closing in favor of #3678

@vondele vondele closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants